| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <19f34abd0801271330j596cd9fbqbd3691548dff26@mail.gmail.com> Date: Sun, 27 Jan 2008 22:30:10 +0100 From: "Vegard Nossum" <vegard.nossum@...il.com> To: "Pekka J Enberg" <penberg@...helsinki.fi> Cc: "Jim Houston" <jim.houston@...r.com>, "Ingo Molnar" <mingo@...e.hu>, "Tejun Heo" <htejun@...il.com>, "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org> Subject: Re: lib/idr.c: initialize struct idr_layer On Jan 27, 2008 10:21 PM, Pekka J Enberg <penberg@...helsinki.fi> wrote: > On Sun, 27 Jan 2008, Vegard Nossum wrote: > > Though in this case, idr_pre_get() actually *is* called first. Hmm... > > I think there's a pretty big chance that kmemcheck is at fault :-( > > Depends on how you track object initialization. An object returned by > kmem_cache_alloc() is always initialized if the cache it comes from has a > constructor. I think there's a pretty big chance I'm wrong (or misunderstanding something) here, so I'll just ask: setup_object() from mm/slub.c is what calls the ctor. Shouldn't this be called from slab_alloc() as well? (I'm marking the data "uninitialized" there before returning the object.) Otherwise you might get back an object that is initialized with the previous owner's data. Or is this intentional? Thanks. Vegard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists