linux-kernel - Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080127220104.GA3503@elte.hu>
Date:	Sun, 27 Jan 2008 23:01:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
Cc:	Dmitri Vorobiev <dmitri.vorobiev@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c


* Paolo Ciarrocchi <paolo.ciarrocchi@...il.com> wrote:

> On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <dmitri.vorobiev@...il.com> wrote:
> > > -  math_abort(FPU_info,SIGILL);
> > > +  math_abort(FPU_info , SIGILL);
> >
> > Looks like you're trading bad for worse here.
> 
> Should I make it read like math_abort(FPU_info, SIGILL); ?

yeah, that's the correct one.

> > While you're at it, please think about adding proper KERN_ facility to these printk() calls.
> 
> Yes, basically all the warnings are about missing KERN_. Do you want 
> me to add KERN_ERR to all the above printk?

Do that in a separate patch though, as it changes strings. (and hence 
the checking for 'did the object md5 change' misfires)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/