linux-kernel - Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801271438k1a71f2f3j3d0a2969f1c834be@mail.gmail.com>
Date:	Sun, 27 Jan 2008 23:38:59 +0100
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Dmitri Vorobiev" <dmitri.vorobiev@...il.com>
Cc:	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <dmitri.vorobiev@...il.com> wrote:
[..]
>
> Is there any point in changing code inside the #if 0/#endif block?

Just to avoid checkpatch complaints :-)

> > @@ -76,10 +74,10 @@ void Un_impl(void)
> >  /*
> >     Called for opcodes which are illegal and which are known to result in a
> >     SIGILL with a real 80486.
> > -   */
> > +*/
> >  void FPU_illegal(void)
> >  {
> > -  math_abort(FPU_info,SIGILL);
> > +  math_abort(FPU_info, SIGILL);
> >  }
> >
> >
> > @@ -88,61 +86,69 @@ void FPU_printall(void)
> >  {
> >    int i;
> >    static const char *tag_desc[] = { "Valid", "Zero", "ERROR", "Empty",
> > -                              "DeNorm", "Inf", "NaN" };
> > +                                     "DeNorm", "Inf", "NaN" };
>
> Umm... Why?

I'll remove it.

Thanks.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/