lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 27 Jan 2008 23:48:48 +0100
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Dmitri Vorobiev" <dmitri.vorobiev@...il.com>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

On Jan 27, 2008 11:42 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Dmitri Vorobiev <dmitri.vorobiev@...il.com> wrote:
>
> > Looks like it would be better to proceed in the following manner:
> >
> > 1) remove dead code (no md5 change);
> > 2) reformat the lines to use tabs, not spaces (no md5 change);
> > 3) address the "else-braces" and "single statement block" errors
> >    (no md5 change);
> > 4) remove all unnecessary spaces (no md5 change);
> > 5) add the KERN_ macros (md5 will change).
> > 6) address remaining checkpatch complaints (no md5 change wrt #5
> >    above).
> >
> > Each item above might get into a separate patch.
>
> agreed, that looks like a sensible splitup for such larger cleanup
> patches.
>
> (also, a debug switch that disabled the FPU on modern CPUs and which
> forced math-emu would be nice as well.)

OK, I'll do what you both suggested.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ