linux-kernel - Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080126220029.98dc3826.akpm@linux-foundation.org>
Date:	Sat, 26 Jan 2008 22:00:29 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Teigland <teigland@...hat.com>
Cc:	linux-kernel@...r.kernel.org, fabbione@...ntu.com
Subject: Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

> On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <teigland@...hat.com> wrote:
>  void dlm_rcom_in(struct dlm_rcom *rc)
>  {
>  	struct dlm_header *hd = (struct dlm_header *) rc;

aww, c'mon guys, this is nonsense.

	struct dlm_header *hd = &rc->rc_header;

there seems to be rather a lot of this unnecessary casting going on in dlm. 
Please do a hunt-and-exterminate.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/