lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080126220336.a2a3caf7.akpm@linux-foundation.org>
Date:	Sat, 26 Jan 2008 22:03:36 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Matt Helsley <matthltc@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	viro@....linux.org.uk, dhowells@...hat.com, wtaber@...ibm.com,
	owilliam@...ibm.com, rkissel@...ibm.com, hch@....de
Subject: Re: [PATCH] Fix procfs task exe symlink

> On Wed, 23 Jan 2008 10:29:37 -0800 Matt Helsley <matthltc@...ibm.com> wrote:
> 
> Andrew, please consider this patch for inclusion in -mm.
> 
> ...
>

Can't say that we're particularly exercised about mvfs's problems, but the
current way of doing /proc/pid/exe is indeed a nasty hack.

> 
>  fs/binfmt_flat.c          |    3 +
>  fs/exec.c                 |    2 +
>  fs/proc/base.c            |   77 ++++++++++++++++++++++++++++++++++++++++++++++
>  fs/proc/internal.h        |    1 
>  fs/proc/task_mmu.c        |   34 --------------------
>  fs/proc/task_nommu.c      |   34 --------------------
>  include/linux/init_task.h |    8 ++++
>  include/linux/mm.h        |   22 +++++++++++++
>  include/linux/mm_types.h  |    7 ++++
>  include/linux/proc_fs.h   |   14 +++++++-
>  kernel/fork.c             |    3 +
>  mm/mmap.c                 |   22 ++++++++++---
>  mm/nommu.c                |   15 +++++++-
>  13 files changed, 164 insertions(+), 78 deletions(-)

It's a fairly expensive fix though.  Can't we just do a strcpy() somewhere
at exec time?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ