linux-kernel - Re: [PATCH] remove duplicating priority setting in try_to_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080128010102.8cbcbdda.akpm@linux-foundation.org>
Date:	Mon, 28 Jan 2008 01:01:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"minchan kim" <minchan.kim@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	"Martin Bligh" <mbligh@...igh.org>,
	"Nick Piggin" <nickpiggin@...oo.com.au>
Subject: Re: [PATCH] remove duplicating priority setting in try_to_free_p

On Mon, 28 Jan 2008 15:43:56 +0900 "minchan kim" <minchan.kim@...il.com> wrote:

> > I think this is actually a bugfix.  The code you're removing doesn't do the
> >
> >         if (priority < zone->prev_priority)
> >
> > thing.
> >
> 
> shrink_zones() in try_to_free_pages() already called
> note_zone_scanning_priority().
> So, it have done it.

note_zone_scanning_priority() will only permit ->prev_priority to logically
increase, whereas the code which you've removed will also permit
->prev_priority to logically decrease.  So I don't see that they are
equivalent?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/