linux-kernel - Re: [PATCH -mm 2/2] PWM LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080128103245.32eba006@dhcp-252-066.norway.atmel.com>
Date:	Mon, 28 Jan 2008 10:32:45 +0100
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Brownell <david-b@...bell.net>,
	Andrew Victor <linux@...im.org.za>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Patrice Vilchez <patrice.vilchez@....atmel.com>,
	Richard Purdie <rpurdie@...ys.net>,
	linux-kernel@...r.kernel.org, kernel@...32linux.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [PATCH -mm 2/2] PWM LED driver

On Mon, 28 Jan 2008 01:29:32 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > -	if (i > 0) {
> > -		for (i = i - 1; i >= 0; i--) {
> > -			led_classdev_unregister(&leds[i].cdev);
> > -			pwm_channel_free(&leds[i].pwmc);
> > -		}
> > +	while (i-- > 0) {
> > +		led_classdev_unregister(&leds[i].cdev);
> > +		pwm_channel_free(&leds[i].pwmc);
> >  	}  
> 
> Looks OK, although I'd say that `while (--i >= 0)' is more idiomatic -
> predecrement, postincrement and all that?

Maybe. while (i-- > 0) has the advantage that it will work even if i is
unsigned though...

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/