linux-kernel - Re: [PATCH] x86: fix usage of .section .sched.text in assembler code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080128101333.GB24010@elte.hu>
Date:	Mon, 28 Jan 2008 11:13:34 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: fix usage of .section .sched.text in assembler
	code


* Sam Ravnborg <sam@...nborg.org> wrote:

> Without this patch the linker will generate a section named 
> .sched.text.1 which is unexpected. This is because the gcc generated 
> section has "ax" but the assembler usage of .sched.text lacks the "ax" 
> specifier.

thanks, applied.

> It would be better to have a definition we could use from assembler 
> code but I did not find a suitable header file for it.

hm, include/asm-x86/linkage.h?

btw., i guess this in include/linux/linkage.h:

#ifndef __ALIGN
#define __ALIGN         .align 4,0x90
#define __ALIGN_STR     ".align 4,0x90"
#endif

is an x86-ism (0x90 is the x86 NOP instruction) that should move into 
include/asm-x86/linkge.h and the default filler should be 0x00 instead?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/