linux-kernel - Re: [PATCH -mm v4 7/9] atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080128022000.82ac86ab.akpm@linux-foundation.org>
Date:	Mon, 28 Jan 2008 02:20:00 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>
Cc:	linux@...im.org.za, linux@...mer.net, coldwell@...hat.com,
	marc.pignat@...s.ch, david-b@...bell.net,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH -mm v4 7/9] atmel_serial: Add DMA support

On Mon, 28 Jan 2008 10:59:09 +0100 Haavard Skinnemoen <hskinnemoen@...el.com> wrote:

> > ho-hum.  The generic uart buffer-handling code does ringbuffers the wrong
> > way.  Maybe it has to handle non-power-of-two buffer sizes.
> 
> Hmm...I don't understand. What does it do wrong?

An faq ;) If the buffer size is a power-of-two it's better to allow the
head and tail indices wrap through 0xffffffff and only mask them when
subscripting.  It ends up faster (usually) and you can use all of the
elements of the buffer (rather than all-1) and you get nice things like:

is_empty = (head == tail)
is_full = (tail - head == size)
nr_items_in_ring = (tail - head)


> > > +		/* more to transmit - setup next transfer */
> > > +
> > > +		/* disable PDC transmit */
> > > +		UART_PUT_PTCR(port, ATMEL_PDC_TXTDIS);
> > > +		dma_sync_single_for_device(port->dev,
> > > +					   pdc->dma_addr,
> > > +					   pdc->dma_size,
> > > +					   DMA_TO_DEVICE);
> > > +
> > > +		if (xmit->tail < xmit->head)
> > > +			count = xmit->head - xmit->tail;
> > > +		else
> > > +			count = SERIAL_XMIT_SIZE - xmit->tail;
> > 
> > Doesn't uart_circ_chars_pending() do this?
> 
> Hmm...no. I think we really want something CIRC_CNT_TO_END()-ish.
> 
> > All those uart_circ_*() macros reference their arg more than once and ... 
> > you know the deal.
> 
> Yeah. Would you like a patch that inline-ifies <linux/circ.h>?

uh, if you're feeling especially keen.  We have bigger problems than this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/