linux-kernel - [RFC][PATCH 0/2] hrtimer breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080128103953.326762000@chello.nl>
Date:	Mon, 28 Jan 2008 11:39:53 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	rth@...ddle.net, rmk@....linux.org.uk, bryan.wu@...log.com,
	dhowells@...hat.com, gerg@...inux.org, lethal@...ux-sh.org,
	wli@...omorphy.com, davem@...emloft.net
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu, torvalds@...ux-foundation.org,
	a.p.zijlstra@...llo.nl
Subject: [RFC][PATCH 0/2] hrtimer breakage

Hi,

If you're in the To: field, I broke your arch with (post .24) commit:
  d3d74453c34f8fd87674a8cf5b8a327c68f22e99

So, to be clear, that broke:
  alpha, arm, blackfin, frv, m68knommu, sh, sh64 and sparc

The deadlock resulting was found by Russell:

  IRQ handle 
    -> timer_tick() - xtime seqlock held for write
      -> update_process_times() 
        -> run_local_timers()
          -> hrtimer_run_queues()
            -> hrtimer_get_softirq_time() - tries to get a read lock

Now, Thomas assures me the fix is trivial, only do_timer() needs to be
done under the xtime_lock, and update_process_times() can savely be removed
from under it.

So that is what the next two patches do, the first patch is by Russell and
covers most of the arm sub-arch, the second one does the other archs and a
few arm archs that were missed by rmk.

This patch should probably be folded into one, or at least the arm bits
from the second moved to the first patch, to avoid more bisect breakage.

If you're all ok I'll polish the patches (maybe one per arch?) and ask for
merger.

(for obvious reasons I'm unable to actually test any of this)

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/