linux-kernel - Re: [PATCHv2 1/9] x86: Unify whitespace and comments in arch/x86/boot/compressed/vmlinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2008 12:03:33 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Ian Campbell <ijc@...lion.org.uk>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCHv2 1/9] x86: Unify whitespace and comments in
	arch/x86/boot/compressed/vmlinux_??.lds

thanks Ian, i've picked up your series into x86.git.

one small nit - when doing cleanups i've been consistently using this 
formatting for comments:

       /*
        * Be careful parts of head_32.S assume startup_32 is at
        * address 0.
        */

instead of:

       /* Be careful parts of head_32.S assume startup_32 is at
        * address 0.
        */

(this is just personal preference, both forms are CodingStyle conform.  
I like the former a bit more because it visually separates comments from 
previous lines of code more. [and comments have rarely any relationship 
to previous code - they apply to the following code lines.] Anyway, no 
need to resend the series - just please keep this in mind for future 
cleanups.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/