linux-kernel - Re: [PATCH 00 of 11] x86: separate pmd lifetime from pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <479E00E0.2030908@goop.org>
Date:	Mon, 28 Jan 2008 08:20:48 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Jan Beulich <jbeulich@...ell.com>,
	Eduardo Pereira Habkost <ehabkost@...hat.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	H Peter Anvin <hpa@...or.com>
Subject: Re: [PATCH 00 of 11] x86: separate pmd lifetime from pgd

Ingo Molnar wrote:
> and after a session of bisection, the winner patch is:
>
>   Subject: x86: unify PAE/non-PAE pgd_ctor
>
> which is a tad unexpected, given the relatively harmless nature of the 
> patch. (but then again, nothing is really harmless in PAE land.)
>   

Oh, well, good.  At least off-the-cuff diagnosis was right.  I must have 
overlooked some detail in that merge.

> btw., this is not fair i think: your patch was apparently caught by the 
> new debugging helper that tells about itself here:
>
>   
>> [   29.389872] debug: unmapping init memory c0b03000..c0b6f000
>>     
>
> note the close proximity of c0b6f000 and ebx = c0b6fc08. [ I regularly 
> come up with such nasty tricks and debugging helpers like that to catch 
> bad patches off-guard. You have been warned! ;-) ]
>   

Hm, perhaps, but it could be as easily coincidence.  The place there 
initmem is freed is close to where it first needs to rely on a 
non-initmm pagetable.  I presume that message means that c0b6f000 was 
*not* freed.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/