linux-kernel - Re: git-x86 oopses in acpi_ps_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080128181113.GA5375@elte.hu>
Date:	Mon, 28 Jan 2008 19:11:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, jeremy@...p.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: git-x86 oopses in acpi_ps_peek_opcode


* Andi Kleen <andi@...stfloor.org> wrote:

> > do you still see that crash?
> 
> New the second oops in 
> allocate_threshold_blocks->sysfs_add_file->kobject_uevent_env happens 
> (see other mail)

that's a Linus -git problem, the upstream kobject changes - try Greg's 
and Yinghai Lu's patch below, does it help?

	Ingo

Index: linux-x86.q/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
+++ linux-x86.q/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
@@ -450,7 +450,8 @@ recurse:
 	if (err)
 		goto out_free;
 
-	kobject_uevent(&b->kobj, KOBJ_ADD);
+	if (b)
+		kobject_uevent(&b->kobj, KOBJ_ADD);
 
 	return err;
 
@@ -553,8 +554,9 @@ static __cpuinit int threshold_create_de
 	unsigned int bank;
 	int err = 0;
 
+	printk(KERN_DEBUG "threshold_create_device: cpu %d, bank_map=%02x\n", cpu, per_cpu(bank_map,cpu));
 	for (bank = 0; bank < NR_BANKS; ++bank) {
-		if (!(per_cpu(bank_map, cpu) & 1 << bank))
+		if (!(per_cpu(bank_map, cpu) & (1 << bank)))
 			continue;
 		err = threshold_create_bank(cpu, bank);
 		if (err)
@@ -637,7 +639,7 @@ static void threshold_remove_device(unsi
 	unsigned int bank;
 
 	for (bank = 0; bank < NR_BANKS; ++bank) {
-		if (!(per_cpu(bank_map, cpu) & 1 << bank))
+		if (!(per_cpu(bank_map, cpu) & (1 << bank)))
 			continue;
 		threshold_remove_bank(cpu, bank);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/