[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0801281107200.14323@schroedinger.engr.sgi.com>
Date: Mon, 28 Jan 2008 11:09:09 -0800 (PST)
From: Christoph Lameter <clameter@....com>
To: Andrew Morton <akpm@...ux-foundation.org>
cc: Shaohua Li <shaohua.li@...el.com>, nickpiggin@...oo.com.au,
linux-kernel@...r.kernel.org
Subject: Re: [RFC] some page can't be migrated
On Sat, 26 Jan 2008, Andrew Morton wrote:
> We call something(GFP_KERNEL) under rcu_read_lock()? I've lost track of
> the myriad flavours of rcu which we purport to support, but I don't think
> they'll all like us blocking under rcu_read_lock().
>
> We _won't_ block, because try_to_release_page() will see the NULL ->mapping
> and will call the non-blocking try_to_free_buffers(). But still, it looks
> bad, and will cause problems if someone decides to add a might_sleep_if()
> to try_to_release_page().
>
> So... I'd suggest that it would be better to add an apologetic comment and
> call direct into try_to_free_buffers().
Right. Looks good. PageWriteback cannot be set if we do not have a
mappig...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists