linux-kernel - Re: [2.6 patch] dvb/frontends/tda18271-common.c: fix off-by-one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <479E53B8.6030505@linuxtv.org>
Date:	Mon, 28 Jan 2008 17:14:16 -0500
From:	mkrufky@...uxtv.org
To:	bunk@...nel.org
Cc:	mchehab@...radead.org, v4l-dvb-maintainer@...uxtv.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] dvb/frontends/tda18271-common.c: fix off-by-one

Adrian Bunk wrote:
> This patch fixes an off-by-one error spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>   
Reviewed-by: Michael Krufky <mkrufky@...uxtv.org>

Thank you, Adrian.

Mauro, please merge this and queue for upstream.

Cheers,

Mike


> ---
> --- linux-2.6/drivers/media/dvb/frontends/tda18271-common.c.old
2008-01-28 16:27:55.000000000 +0200
> +++ linux-2.6/drivers/media/dvb/frontends/tda18271-common.c	2008-01-28
16:28:38.000000000 +0200
> @@ -166,17 +166,17 @@ int tda18271_read_extended(struct dvb_fr
>  	/* read all registers */
>  	ret = i2c_transfer(priv->i2c_adap, msg, 2);
>  
>  	tda18271_i2c_gate_ctrl(fe, 0);
>  
>  	if (ret != 2)
>  		tda_err("ERROR: i2c_transfer returned: %d\n", ret);
>  
> -	for (i = 0; i <= TDA18271_NUM_REGS; i++) {
> +	for (i = 0; i < TDA18271_NUM_REGS; i++) {
>  		/* don't update write-only registers */
>  		if ((i != R_EB9)  &&
>  		    (i != R_EB16) &&
>  		    (i != R_EB17) &&
>  		    (i != R_EB19) &&
>  		    (i != R_EB20))
>  		regs[i] = regdump[i];
>  	}
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/