linux-kernel - Re: [2.6 patch] ata_piix.c: make piix_merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jan 2008 08:02:28 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Jeff Garzik <jeff@...zik.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] ata_piix.c: make piix_merge_scr() static

Adrian Bunk wrote:
> piix_merge_scr() can become static.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> f272ad2ac4274a59f0b43cfd65488c51855132d4 
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a65c8ae..1a5c3bf 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
>  	iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
>  }
>  
> -u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
> +static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
>  {
>  	u32 val = 0;
>  	int i, mi;

Ah.. right.  Thanks.  I somehow forgot static in front of it.

Acked-by: Tejun Heo <htejun@...il.com>

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/