[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <479F7B43.6090801@cs.wisc.edu>
Date: Tue, 29 Jan 2008 13:15:15 -0600
From: Mike Christie <michaelc@...wisc.edu>
To: Konrad Rzeszutek <konrad@...nok.org>
CC: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Greg KH <greg@...ah.com>,
dwm@...yolf.org, darnok@....org, pjones@...hat.com,
konradr@...hat.com, konradr@...ux.vnet.ibm.com,
randy.dunlap@...cle.com, hpa@...or.com, lenb@...nel.org,
mike.anderson@...ibm.com, dwm@...tin.ibm.com, arjan@...radead.org,
Andy Whitcroft <apw@...dowen.org>,
James.Bottomley@...senpartnership.com
Subject: Re: [PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header
files.
Konrad Rzeszutek wrote:
> +/*
> + * Helper functions to parse data properly.
> + */
> +static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
> +{
> + if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 &&
> + ip[4] == 0 && ip[5] == 0 && ip[6] == 0 && ip[7] == 0 &&
> + ip[8] == 0 && ip[9] == 0 && ip[10] == 0xff && ip[11] == 0xff) {
> + /*
> + * IPV4
> + */
> + return sprintf(buf, "%d.%d.%d.%d\n", ip[12],
> + ip[13], ip[14], ip[15]);
> + } else
> + return 0;
> +}
You probably just want to use the NIPQUAD_FMT and NIP6_FMT macros here.
Also why isn't ipv6 supported?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists