linux-kernel - Re: [PATCH 17/22 -v7] mcount tracer for wakeup latency timings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1201685469.28547.172.camel@lappy>
Date:	Wed, 30 Jan 2008 10:31:09 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Gregory Haskins <ghaskins@...ell.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tim Bird <tim.bird@...sony.com>,
	Sam Ravnborg <sam@...nborg.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	John Stultz <johnstul@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 17/22 -v7] mcount tracer for wakeup latency timings.


On Tue, 2008-01-29 at 22:15 -0500, Steven Rostedt wrote:

> +static void notrace __wakeup_reset(struct tracing_trace *tr)
> +{
> +	struct tracing_trace_cpu *data;
> +	int cpu;
> +
> +	assert_spin_locked(&wakeup_lock);
> +
> +	for_each_possible_cpu(cpu) {
> +		data = tr->data[cpu];
> +		tracing_reset(data);
> +	}
> +
> +	wakeup_cpu = -1;
> +	wakeup_prio = -1;
> +	if (wakeup_task) {
> +		put_task_struct(wakeup_task);
> +		tracing_stop_function_trace();
> +	}
> +
> +	wakeup_task = NULL;
> +
> +	/*
> +	 * Don't let the trace_enabled = 1 show up before
> +	 * the wakeup_task is reset.
> +	 */
> +	smp_wmb();
> +}

Another un-balanced barrier.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/