linux-kernel - Re: [PATCH] [SIS190] Constify data marked as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801301220570.15249@fbirervta.pbzchgretzou.qr>
Date:	Wed, 30 Jan 2008 12:23:23 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Jonas Bonn <jonas@...thpole.se>
cc:	netdev@...r.kernel.org, romieu@...zoreil.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [SIS190] Constify data marked as __devinitdata


On Jan 30 2008 11:53, Jonas Bonn wrote:
>
>This fixes build error as gcc complains about a "section type conflict"
>due to the const __devinitdata in sis190_get_mac_addr_from_apc().

>-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
>+static const struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
> 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
> 	{ 0, },

Eh? Did you mean to

-        static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
+        static u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };

instead? Because AFAIK, const *and* __sectionmarker does not mix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/