lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jan 2008 08:40:25 -0500 (EST) From: Steven Rostedt <rostedt@...dmis.org> To: Peter Zijlstra <a.p.zijlstra@...llo.nl> cc: LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, Christoph Hellwig <hch@...radead.org>, Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>, Gregory Haskins <ghaskins@...ell.com>, Arnaldo Carvalho de Melo <acme@...stprotocols.net>, Thomas Gleixner <tglx@...utronix.de>, Tim Bird <tim.bird@...sony.com>, Sam Ravnborg <sam@...nborg.org>, "Frank Ch. Eigler" <fche@...hat.com>, Jan Kiszka <jan.kiszka@...mens.com>, John Stultz <johnstul@...ibm.com>, Arjan van de Ven <arjan@...radead.org>, Steven Rostedt <srostedt@...hat.com> Subject: Re: [PATCH 19/22 -v7] trace preempt off critical timings On Wed, 30 Jan 2008, Peter Zijlstra wrote: > > On Tue, 2008-01-29 at 22:15 -0500, Steven Rostedt wrote: > > > +static DEFINE_PER_CPU(int, tracing_cpu); > > Is the per-cpu tracing not also needed for irq off tracing? The preempt off code shares the irq off code. With irq off only (before this patch) all that was needed was to check if trace_enabled is set or not. Now that the preempt off code is coupled with the irqs off code, we may hit some paths where tracing is enabled but we are not currently tracing. This variable was added to facilitate this knowledge. > > Also, its not mentioned in the changelog. It was more of an internal design change than a feature. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists