linux-kernel - Re: [PATCH] fix tasklist + find_pid() with CONFIG_PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1201702653.28547.219.camel@lappy>
Date:	Wed, 30 Jan 2008 15:17:33 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Oleg Nesterov <oleg@...sign.ru>, ebiederm@...ssion.com,
	mingo@...e.hu, paulmck@...ux.vnet.ibm.com, xemul@...nvz.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix tasklist + find_pid() with CONFIG_PREEMPT_RCU


On Tue, 2008-01-29 at 15:02 -0800, Andrew Morton wrote:
> On Tue, 29 Jan 2008 19:40:19 +0300
> Oleg Nesterov <oleg@...sign.ru> wrote:
> 
> > With CONFIG_PREEMPT_RCU read_lock(tasklist_lock) doesn't imply rcu_read_lock(),
> 
> I'm suspecting that we have other code which assumes that read_lock, write_lock
> and spin_lock imply rcu_read_lock().
> 
> I wonder if there are any sane runtime checks we can put in there to find
> such problems.

I have a lockdep annotation that finds rcu_dereference() usages outside
of rcu_read_lock().

Trouble is the amazing amount of output, I haven't come round to going
through it and annotation the false positives (think rcu safe library
routines called from contexts where the rcu capability is not used).



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/