linux-kernel - Re: [PATCH] lib: Add support for DIF CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801301555450.15249@fbirervta.pbzchgretzou.qr>
Date:	Wed, 30 Jan 2008 15:56:56 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: Add support for DIF CRC

On Jan 30 2008 02:00, Martin K. Petersen wrote:
>diff -r f5ec697e8b10 include/linux/crc-t10dif.h
>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/include/linux/crc-t10dif.h	Tue Jan 29 13:26:19 2008 -0500
>@@ -0,0 +1,9 @@
>+#ifndef _LINUX_CRC_T10DIF_H
>+#define _LINUX_CRC_T10DIF_H
>+
>+#include <linux/types.h>
>+
>+const __u16 t10_dif_crc_table[256];
>+__u16 crc_t10dif(unsigned char const *, size_t);
>+
>+const __u16 t10_dif_crc_table[256] = {
...
>+};
>+
>+__u16 crc_t10dif(const unsigned char *buffer, size_t len)
>+{
...
>+}
>+
>+EXPORT_SYMBOL(crc_t10dif);

One minor nitpick still: if t10_dif_crc_table is not EXPORT_SYMBOLed,
it should be static, since I do not see a reason to only make it
available to built-in code.

So either make the table static too, or EXPORT it. I am not sure if
any code needs to access the table directly, though, so I'd be going
for the static.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/