linux-kernel - Re: arch/x86/kernel/test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080130190856.GA4221@elte.hu>
Date:	Wed, 30 Jan 2008 20:08:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Arjan van de Ven <arjan@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: arch/x86/kernel/test_nx.c compile error


* Adrian Bunk <bunk@...nel.org> wrote:

> > +#ifdef CONFIG_X86_32
> > +		"	.long 0b\n"
> > +		"	.long 2b\n"
> > +#endif
> >  		"	.quad 0b\n"
> >  		"	.quad 2b\n"
> > +#else
> >...
> 
> You don't test whether your patches compile?  ;-)

i did - but i didnt test whether i sent you the right, fixed one :-)

> After the obvious fix it compiled.
> 
> Why wasn't this issue found before it entered Linus' tree?

because it was a relatively late patch and TEST_NX is dependent on a 
modular build - which i dont test that often. I found and fixed a mirror 
image bug in test_rodata.c.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/