linux-kernel - Re: PATCH] x86_64: make bootmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <200801301215.51645.yinghai.lu@sun.com>
Date:	Wed, 30 Jan 2008 12:15:50 -0800
From:	Yinghai Lu <Yinghai.Lu@....COM>
To:	Andi Kleen <ak@...e.de>
Cc:	Ingo Molnar <mingo@...e.hu>, Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: PATCH] x86_64: make bootmap_start page align v4

On Wednesday 30 January 2008 11:08:32 am Andi Kleen wrote:
> 
> > +	/*
> > +	 * when you have 64g or 128g ram, bootmap will be pushed after bss
> > +	 * section, the bootmap we get from early_node_mem via find_e820_area
> > +	 * is not page aligned, we need to round it up to  make sure bootmap
> > +	 * is not overlapped with bss section
> > +	 */
> > +	bootmap_start = round_up(bootmap_start, PAGE_SIZE);
> 
> The better solution would be to PAGE_ALIGN() the addresses
> in bad_addr(). Or better fix it that no such alignment is needed to not 
> get conflicts. 

I don't think so, that is setup_node_bootmem's problem. 

it is supposed to round_up instead of just do PAGE_SHIFT...

other caller will just use the address instead change it page.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/