linux-kernel - [PATCH] don't prefer unsuited consoles on registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <479FC0B6.8000607@web.de>
Date:	Wed, 30 Jan 2008 01:11:34 +0100
From:	Jan Kiszka <jan.kiszka@....de>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
CC:	Jason Wessel <jason.wessel@...driver.com>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] don't prefer unsuited consoles on registration

KGDB triggers a (probably so far theoretical) issue of the automatic
init console election: If some console happens to be registered first
which does not provide a tty binding (!console->device), it prevents
that more suited consoles which are registered later on can enter the
candidate pool for console_device(). This is observable with KGDB's
console which may already be registered (and exploited!) during early
debugger connections, that is before any regular console registration.

This patch fixes the issue by postponing the final, automated
preferred_console selection until someone with a non-NULL device
handler comes around.

Signed-off-by: Jan Kiszka <jan.kiszka@....de>

---
 kernel/printk.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: b/kernel/printk.c
===================================================================
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1126,8 +1126,11 @@ void register_console(struct console *co
 			console->index = 0;
 		if (console->setup == NULL ||
 		    console->setup(console, NULL) == 0) {
-			console->flags |= CON_ENABLED | CON_CONSDEV;
-			preferred_console = 0;
+			console->flags |= CON_ENABLED;
+			if (console->device) {
+				console->flags |= CON_CONSDEV;
+				preferred_console = 0;
+			}
 		}
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/