linux-kernel - Re: [patch 6/6] mm: bdi: allow setting a maximum for the bdi dirty limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2008 16:39:27 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch 6/6] mm: bdi: allow setting a maximum for the bdi dirty
 limit

On Tue, 29 Jan 2008 16:49:06 +0100
Miklos Szeredi <miklos@...redi.hu> wrote:

> Add "max_ratio" to /sys/class/bdi.  This indicates the maximum
> percentage of the global dirty threshold allocated to this bdi.

Maybe I'm having a stupid day, but I don't understand the semantics of this
min and max at all.  I've read the code, and I've read the comments (well,
I've hunted for some) and I've read the docs.

I really don't know how anyone could use this in its current state without
doing a lot of code-reading and complex experimentation.  All of which
would be unneeded if this tunable was properly documented.

So.  Please provide adequate documentation for this tunable.  I'd suggest
that it be pitched at the level of a reasonably competent system operator. 
It should help them understand why the tunable exists, why they might
choose to alter it, and what effects they can expect to see.  Hopefully a
reaonably competent kernel developer can then understand it too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/