linux-kernel - Re: about relocs.c on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2008 10:52:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: about relocs.c on x86

* Yinghai Lu <yhlu.kernel@...il.com> wrote:

> why not rename relocs.c to relocs_32.c?
> 
> it is only used for 32 bit, even it is host app.

during the big first phase of unification we generally kept file names 
untouched if they were only present in one of the previous 
architectures. I.e. pure 32-bit and pure 64-bit files were not renamed 
to _32/_64.

Now that we've got lots of unified 32/64-bit files it might make sense 
to rename the 'standalone' ones into _32/_64 if they share the same 
directory with 32/64-bit source files - to reduce the confusion. And 
given that for example arch/x86/boot/compressed/misc.c is unified while 
arch/x86/boot/compressed/relocs.c is 32-bit only, i'd agree with your 
observation. Feel free to send a rename patch for such cases.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/