linux-kernel - Re: PATCH] x86_64: fix comments in vmlinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080131123503.GG12571@elte.hu>
Date:	Thu, 31 Jan 2008 13:35:03 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: PATCH] x86_64: fix comments in vmlinux_64.lds


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

>  ENTRY(startup_64)
>  SECTIONS
>  {
> -	/* Be careful parts of head_64.S assume startup_64 is at
> +	/* Be careful parts of head_64.S assume startup_32 is at
>  	 * address 0.
>  	 */
>  	. = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's 
linked to a different address that is not 0:

 ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

 ffffffff80200000 T startup_64

So your patch looks wrong to me.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/