linux-kernel - Re: [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080131132438.GC8499@elte.hu>
Date:	Thu, 31 Jan 2008 14:24:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Andi Kleen <ak@...e.de>, Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and
	bootmap


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> ok, discard 3, and 4.
> 
> how about 2 v2?

i'm leaning towards v4, but the more fundamental breakage is in the 
early_node_mem() ad-hoc allocator that got butchered into this code a 
year ago:

  commit a8062231d80239cf3405982858c02aea21a6066a
  Author: Andi Kleen <ak@...e.de>
  Date:   Fri Apr 7 19:49:21 2006 +0200

      [PATCH] x86_64: Handle empty PXMs that only contain hotplug memory

  ...
  +static void * __init
  +early_node_mem(int nodeid, unsigned long start, unsigned long end,
  +             unsigned long size)

and we are now suffering the side-effects of that hack.

what i suspect we need instead is a proper early-allocator that works in 
the e820 space.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/