linux-kernel - Re: [PATCH 3/4] IB: add dmabarrier to ib_umem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adar6fyajkw.fsf@cisco.com>
Date:	Wed, 30 Jan 2008 17:07:43 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	akepner@....com
Cc:	Tony Luck <tony.luck@...el.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Jes Sorensen <jes@....com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	David Miller <davem@...emloft.net>,
	Muli Ben-Yehuda <muli@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] IB: add dmabarrier to ib_umem_get() prototype

 > diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
 > index 4e3128f..5b00408 100644
 > --- a/drivers/infiniband/core/umem.c
 > +++ b/drivers/infiniband/core/umem.c
 > @@ -74,7 +74,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
 >   * @access: IB_ACCESS_xxx flags for memory being pinned
 >   */
 >  struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
 > -			    size_t size, int access)
 > +			    size_t size, int access, int dmabarrier)
 >  {
 >  	struct ib_umem *umem;
 >  	struct page **page_list;

Two problems here, one major: this doesn't actually do anything with
the dmabarrier parameter, and one minor: it also doesn't add any
documentation for the parameter to the comment before the function.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/