linux-kernel - Re: [PATCH] [6/9] GBPAGES: Add gbpages support to lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0801311659490.9204@apollo.tec.linutronix.de>
Date:	Thu, 31 Jan 2008 17:02:25 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <ak@...e.de>
cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [6/9] GBPAGES: Add gbpages support to lookup_address

On Tue, 29 Jan 2008, Andi Kleen wrote:

> 
> Signed-off-by: Andi Kleen <ak@...e.de>
> 
> ---
>  arch/x86/mm/pageattr.c    |    5 +++++
>  include/asm-x86/pgtable.h |    1 +
>  2 files changed, 6 insertions(+)
> 
> Index: linux/arch/x86/mm/pageattr.c
> ===================================================================
> --- linux.orig/arch/x86/mm/pageattr.c
> +++ linux/arch/x86/mm/pageattr.c
> @@ -152,9 +152,14 @@ pte_t *lookup_address(unsigned long addr
>  
>  	if (pgd_none(*pgd))
>  		return NULL;
> +
> +	*level = PG_LEVEL_1G;
>  	pud = pud_offset(pgd, address);
>  	if (pud_none(*pud))
>  		return NULL;

Please move the level update here, so it is consistent with PMD.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/