linux-kernel - [PATCH] remove device mapper max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200801311909.11752.efocht@hpce.nec.com>
Date:	Thu, 31 Jan 2008 19:09:10 +0100
From:	Erich Focht <efocht@...e.nec.com>
To:	dm-devel@...hat.com
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <jens.axboe@...cle.com>
Subject: [PATCH] remove device mapper max_sectors restriction

The maximum size of a bio is restricted by DM to BLK_DEF_MAX_SECTORS
although the I/O size can be increased for each member device above this
value by using the /sys/block/queue/max_sectors interface.

IMHO the limitation when loading the dm table is unnecessary, the values
for sub-devices are checked while set through the sysfs interface and
the restrictions of the sub-devices are combined, the minimal values are
used for the DM queue. Chopping this additionally to BLK_DEF_MAX_SECTORS
makes it impossible to use IOs bigger than 512KB on big RAIDs accessed
through multipath, even if the devices may support them. The trivial patch
removes this limitation. Sub-devices' max_sectors need to be set before
creating the DM device.

Patch is against 2.6.24. For older kernels max_hw_sectors needs to be set
additionally.

Signed-off-by: Erich Focht <efocht@...e.nec.com>
---
 dm-table.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.24/drivers/md/dm-table.c.orig	2008-01-31 17:06:30.000000000 +0100
+++ linux-2.6.24/drivers/md/dm-table.c	2008-01-31 17:34:03.000000000 +0100
@@ -901,10 +901,10 @@
 void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q)
 {
 	/*
-	 * Make sure we obey the optimistic sub devices
+	 * Make sure we obey the minimum of the sub devices
 	 * restrictions.
 	 */
-	blk_queue_max_sectors(q, t->limits.max_sectors);
+	q->max_sectors = t->limits.max_sectors;
 	q->max_phys_segments = t->limits.max_phys_segments;
 	q->max_hw_segments = t->limits.max_hw_segments;
 	q->hardsect_size = t->limits.hardsect_size;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/