linux-kernel - Re: [PATCH 6/7] X86: include missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801311457x3edc67eap16c03f511dca506b@mail.gmail.com>
Date:	Fri, 1 Feb 2008 02:27:57 +0330
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Joe Perches" <joe@...ches.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/7] X86: include missing KERN_ facility level

On 1/29/08, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2008-01-29 at 00:08 +0100, Paolo Ciarrocchi wrote:
> > \diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
> > index 6102fe0..569a62e 100644
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -57,65 +57,65 @@ void FPU_printall(void)
> >
> >    RE_ENTRANT_CHECK_OFF;
> >    /* No need to check access_ok(), we have previously fetched these
> bytes. */
> > -  printk("At %p:", (void *) address);
> > +  printk(KERN_ERR "At %p:", (void *) address);
> >    if (FPU_CS == __USER_CS) {
> >  #define MAX_PRINTED_BYTES 20
> >        for (i = 0; i < MAX_PRINTED_BYTES; i++) {
> >  	  FPU_get_user(byte1, (u_char __user *) address);
> >  	  if ((byte1 & 0xf8) == 0xd8) {
> > -	      printk(" %02x", byte1);
> > +	      printk(KERN_ERR " %02x", byte1);
> >  	      break;
> >  	    }
> > -	  printk(" [%02x]", byte1);
> > +	  printk(KERN_ERR " [%02x]", byte1);
> >  	  address++;
> >  	}
>
> KERN_ prefixes are used only at the start of a line.
> You should probably use print_hex_dump.


Thank you. I'll redo the patch.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/