linux-kernel - Re: x86 arch updates also broke s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080201100235.GA5519@elte.hu>
Date:	Fri, 1 Feb 2008 11:02:35 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	Adrian Bunk <bunk@...sta.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Nick Piggin <npiggin@...e.de>,
	heiko.carstens@...ibm.com, linux390@...ibm.com
Subject: Re: x86 arch updates also broke s390


* Martin Schwidefsky <schwidefsky@...ibm.com> wrote:

> On Fri, 2008-02-01 at 10:48 +0100, Ingo Molnar wrote:
> > > Defining GENERIC_LOCKBREAK in arch/s390/Kconfig takes care of it.
> > I'll 
> > > cook up a patch and queue it in git390.
> > 
> > the one below should do the trick.
> 
> Thanks but I already queued a different one (see below). The other 
> architectures that define GENERIC_LOCKBREAK have the "depends on SMP 
> && PREEMPT" line as well. The line does make sense if you look at the 
> way how spin_is_contended is used, no ?

yes, you are right and your fix is the correct one. Currently, if we 
define GENERIC_LOCKBREAK on UP then we get accesses to the non-existing 
lock->need_lockbreak field.

[ btw., this is really a small uncleanliness in the generic code: it
  should be possible for an architecture to just enable
  GENERIC_LOCKBREAK unconditionally, to indicate that it intends to "let
  the generic code do this". Then the generic code, when it does not
  have a field (such as on UP), should just not access it. But this is a
  small detail. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/