linux-kernel - [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080201124520.GA29900@elte.hu>
Date:	Fri, 1 Feb 2008 13:45:20 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: [build bug] lguest build failure:
	drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined
	reference to `LGUEST_PAGES_regs_trapnum'


i have just added lguest to the x86 automated testing infrastructure 
back again, and promptly a build failure popped up:

  drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference 
  to `LGUEST_PAGES_regs_trapnum'

(config attached)

i sent the patch below two weeks ago to fix a similar build bug but it's 
not upstream yet AFAICS. It resolves this particular build failure as 
well.

	Ingo

-------------------->
Subject: x86: lguest fix
From: Ingo Molnar <mingo@...e.hu>

this commit:

 commit 84f7466ee20cc094aa38617abfa2f3834871f054
 Author: Rusty Russell <rusty@...tcorp.com.au>
 Date:   Sat Jan 19 07:02:29 2008 +1100

      Selecting LGUEST should turn on Guest support, as in 2.6.23.

caused build failures due to allowing LGUEST to be selected without
paravirt support.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/lguest/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/lguest/Kconfig
===================================================================
--- linux.orig/drivers/lguest/Kconfig
+++ linux/drivers/lguest/Kconfig
@@ -1,6 +1,6 @@
 config LGUEST
 	tristate "Linux hypervisor example code"
-	depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
+	depends on X86_32 && EXPERIMENTAL && PARAVIRT_GUEST && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER)
 	select HVC_DRIVER
 	---help---
 	  This is a very simple module which allows you to run

View attachment "config" of type "text/plain" (45442 bytes)