[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080201023659.GA30057@sgi.com>
Date: Thu, 31 Jan 2008 20:37:00 -0600
From: Jack Steiner <steiner@....com>
To: Robin Holt <holt@....com>
Cc: Christoph Lameter <clameter@....com>,
Andrea Arcangeli <andrea@...ranet.com>,
Avi Kivity <avi@...ranet.com>, Izik Eidus <izike@...ranet.com>,
kvm-devel@...ts.sourceforge.net,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
daniel.blueman@...drics.com
Subject: Re: [patch 1/3] mmu_notifier: Core code
On Thu, Jan 31, 2008 at 08:24:44PM -0600, Robin Holt wrote:
> On Thu, Jan 31, 2008 at 07:56:12PM -0600, Jack Steiner wrote:
> > > @@ -2033,6 +2034,7 @@ void exit_mmap(struct mm_struct *mm)
> > > unsigned long end;
> > >
> > > /* mm's last user has gone, and its about to be pulled down */
> > > + mmu_notifier(invalidate_all, mm, 0);
> > > arch_exit_mmap(mm);
> > >
> >
> > The name of the "invalidate_all" callout is not very descriptive.
> > Why not use "exit_mmap". That matches the function name, the arch callout
> > and better describes what is happening.
>
> This got removed in a later patch. We now only do the release.
Found it, thanks.
Christoph, is it time to post a new series of patches? I've got
as many fixup patches as I have patches in the original posting.
-- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists