lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <200802011051.36943.yinghai.lu@sun.com>
Date:	Fri, 01 Feb 2008 10:51:36 -0800
From:	Yinghai Lu <Yinghai.Lu@....COM>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] make loglevel related commandline to early_param

On Friday 01 February 2008 04:39:39 am Andi Kleen wrote:
> Yinghai Lu <Yinghai.Lu@....COM> writes:
> 
> > diff --git a/init/main.c b/init/main.c
> > index cb81ed1..a774a93 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -232,22 +232,18 @@ EXPORT_SYMBOL(loops_per_jiffy);
> >  
> >  static int __init debug_kernel(char *str)
> >  {
> > -	if (*str)
> > -		return 0;
> >  	console_loglevel = 10;
> >  	return 1;
> 
> The return semantics changes with early_param so you need to change that in all cases to return 0
> (and negative value for errors) 
> 


thanks. I will send another one.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ