linux-kernel - Re: [PATCH] [12/12] GBPAGES: Switch direct mapping setup over to set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47A36FF2.8000804@goop.org>
Date:	Fri, 01 Feb 2008 11:16:02 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <ak@...e.de>
CC:	tglx@...utronix.de, mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [12/12] GBPAGES: Switch direct mapping setup over to
 set_pte

Andi Kleen wrote:
>> Why?  64-bit Xen will need this to be set_pmd if its an update to L2 of
>> the table.
>>     
>
> Then change_page_attr() and hugepages will already not work because they both 
> do exactly that.
>
> And I didn't want to duplicate this manual code for the GBpages case, so i 
> changed it everywhere to the standard way.

It's a bit moot because Xen doesn't support any kind of large page yet, 
but there has been some work in that area.  The main problem with using 
set_pte is that Xen supports trap'n'emulate for pte-level accesses, but 
not for upper levels.

Looks like you're right about the rest of cpa; may as well make it all 
consistent for now, and we can fix it later when the need arises.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/