linux-kernel - Re: [PATCH 1 of 7] x86: convert pgalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2008 10:17:12 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Jan Beulich <jbeulich@...ell.com>,
	Eduardo Pereira Habkost <ehabkost@...hat.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	H Peter Anvin <hpa@...or.com>
Subject: Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote:
> >  
> > -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))
> > -
> > -#define __pmd_free_tlb(tlb,x)   tlb_remove_page((tlb),virt_to_page(x))
> > -#define __pud_free_tlb(tlb,x)   tlb_remove_page((tlb),virt_to_page(x))
> > +extern void __pte_free_tlb(struct mmu_gather *tlb, struct page *pte);
> > +extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);
> > +extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
> 
> Small question: the extern isn't necessary in headers, is it preferred 
> in linux anyway?

generally yes, to make it more visually separate from inlines, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/