linux-kernel - Re: [PATCH 6 of 7] x86: move pud/pgd functions into common asm/pgalloc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2008 11:13:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Jan Beulich <jbeulich@...ell.com>,
	Eduardo Pereira Habkost <ehabkost@...hat.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	H Peter Anvin <hpa@...or.com>
Subject: Re: [PATCH 6 of 7] x86: move pud/pgd functions into common
	asm/pgalloc.h


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Common definitions for 4-level pagetable functions.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@...source.com>
> ---
>  arch/x86/mm/pgtable.c        |    7 ++++++
>  include/asm-x86/pgalloc.h    |   46 ++++++++++++++++++++++++++++++++++++------
>  include/asm-x86/pgalloc_32.h |   24 ---------------------
>  include/asm-x86/pgalloc_64.h |   32 -----------------------------
>  4 files changed, 47 insertions(+), 62 deletions(-)

random-qa found an early bootup hang on 32-bit (config attached).

i bisected it down to this patch of yours. It's a bit large so it's not 
obvious what is happening. Could you please keep patches that do 
functional changes smaller? It's not a problem if the non-functional or 
trivial restructuring patches are larger, but it's a killer for these 
functional ones. I've dropped this one for now, and all the dependent 
patches as well:

Subject: x86: move pud/pgd functions into common asm/pgalloc.h
Subject: x86: move all the pgd_list handling to one place
Subject: x86: rename paravirt_alloc_pt etc after the pagetable structure
Subject: x86: add pud_alloc for 4-level pagetables
Subject: x86/pgtable.h: demacro ptep_set_access_flags
Subject: x86/pgtable.h: demacro ptep_test_and_clear_young
Subject: x86/pgtable.h: demacro ptep_clear_flush_young

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/