linux-kernel - Re: [PATCH 3 of 5] x86/pgtable.h: demacro ptep_set_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 02 Feb 2008 02:20:17 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Jan Beulich <jbeulich@...ell.com>,
	Eduardo Pereira Habkost <ehabkost@...hat.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	H Peter Anvin <hpa@...or.com>, Zach Amsden <zach@...are.com>
Subject: Re: [PATCH 3 of 5] x86/pgtable.h: demacro ptep_set_access_flags

Ingo Molnar wrote:
> another thing: these inlines are a bit fat and they are used in more 
> than one place. Please move them into pgtable.c. The rule of thumb is: 
> if an inline is more than 2 lines big, it is a likely candidate for 
> uninlining. (and even many 2-liners, and even some 1-liners are 
> candidates) Especially under paravirt the MMU inlines grow these update 
> notifiers so they become even fatter.
>   

I agree, but I wanted to keep it semantically equivalent to the 
original.  I'll add a move to out of line patch.

> having functions instead of inlines also simplifies the type 
> dependencies by quite a degree.
>   

Indeed, the floating asm/tlbflush.h is a bit of a wart.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/