linux-kernel - Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2008 11:15:16 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Franck Bui-Huu <vagabon.xyz@...il.com>
Cc:	linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH 1/2] Split list.h and move rcu-protected lists into
 rculist.h

On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <vagabon.xyz@...il.com> wrote:

> Andrew Morton wrote:
> > On Thu, 17 Jan 2008 21:47:38 +0100
> > Franck Bui-Huu <vagabon.xyz@...il.com> wrote:
> > 
> >> This patch moves rcu-protected lists from list.h into a new header
> >> file rculist.h.
> > 
> > I'm getting way too many compilation errors from this, perhaps because of
> > new rcu-list usages which weren't present in the old tree (ie: current
> > Linus mainline) which you tested it against.
> > 
> 
> Not really suprising, sorry for the mess.
> 
> > The most practical way to prepare a patch like this is to either make it
> > back-compatible (for a while at least) or to prepare and carefully test it
> > against latest -mm.  That way you'll pick up everyone's new code.
> > 
> 
> I'll try to come up with something better: if rculist helpers are used from
> list.h then issue a warning otherwise every thing is fine since the helpers
> are imported from rculist.h.
> 
> Do you think it's better ?

Could.  I'd suggest that you redo the header-file split patch around the
2.6.25-rc1 timeframe, test it carefully then let's get it in then.

> In the meanwhile, could you drop the patches related to rculist from mm
> tree ?

I have done so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/