linux-kernel - Re: Some fixes for "Section mismatch" errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 2 Feb 2008 21:42:33 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Peter Teoh <htmldeveloper@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Some fixes for "Section mismatch" errors.

On Sun, Feb 03, 2008 at 12:00:29AM +0800, Peter Teoh wrote:
> Today, I pulled from linus tree, and compile with MANY section
> mismatches errors, eg, some of which are like the following:
> 
> WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x1c9f): Section mismatch
> in reference from the function hdsp_check_for_firmware() to the
> function .devinit.text:hdsp_request_fw_loader()
> WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x35bf): Section mismatch
> in reference from the function snd_hdsp_proc_read() to the function
> .devinit.text:hdsp_request_fw_loader()

Your fix for this particular warning looks OK.
But always do:
-> One fix per patch
-> Include the warning in the patch descript that you fix
-> Explain why you fixed it the way you did it

Without this info it is too time consuming to try to review your patch
and I did nt look at the other changes you included.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/