| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Feb 2008 01:32:31 +0300 From: "Cyrill Gorcunov" <gorcunov@...il.com> To: "H. Peter Anvin" <hpa@...or.com> Cc: "Ingo Molnar" <mingo@...e.hu>, "Andi Kleen" <ak@...e.de>, LKML <linux-kernel@...r.kernel.org>, "Thomas Gleixner" <tglx@...utronix.de> Subject: Re: [RFC] x86: setup code_bytes - use mask to restrict it's size Thanks for review. Agreed with you absolutely. Silly patch, sorry :( On 2/3/08, H. Peter Anvin <hpa@...or.com> wrote: > Cyrill Gorcunov wrote: > > This patch strips off 8 bytes from text section. Not a really > > big advantage (especially for __init section). It seems 8192 > > bytes of disassembled code is rare used anyway. > > > > before: > > text data bss dec hex filename > > 9900 176 20 10096 2770 arch/x86/kernel/traps_64.o.old > > after: > > text data bss dec hex filename > > 9892 176 20 10088 2768 arch/x86/kernel/traps_64.o > > > > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com> > > --- > > > > If there is no benefit at all - just drop the patch. > > Any comments are welcome ;) > > I don't think this is the behaviour we want (wrapping around); worse, if > people enter a larger power of two they will get zero. > > So NAK on this patch, IMO. > > -hpa > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists