linux-kernel - Re: [PATCH] x86: fix compile waring building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47A56DDA.9000907@cn.fujitsu.com>
Date:	Sun, 03 Feb 2008 15:31:38 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL

Ingo Molnar wrote:
> * Li Zefan <lizf@...fujitsu.com> wrote:
> 
>> +#ifdef CONFIG_SYSCTL
>>  static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu);
>> +#endif
> 
> instead of adding another #ifdef, a much cleaner solution would be to 
> just reorder do_nmi_callback() with unknown_nmi_panic_callback(), and 
> eliminate the prototype altogether.
> 
> 	Ingo
> 

I was wondering if a smaller patch will be better. But no doult cleaner
code is better. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/