linux-kernel - Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080203010013.04bc601e.akpm@linux-foundation.org>
Date:	Sun, 3 Feb 2008 01:00:13 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Franck Bui-Huu <vagabon.xyz@...il.com>
Cc:	linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH 1/2] Split list.h and move rcu-protected lists into
 rculist.h

On Sun, 03 Feb 2008 09:45:25 +0100 Franck Bui-Huu <vagabon.xyz@...il.com> wrote:

> Andrew Morton wrote:
> > On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <vagabon.xyz@...il.com> wrote:
> >> Do you think it's better ?
> > 
> > Could.  I'd suggest that you redo the header-file split patch around the
> > 2.6.25-rc1 timeframe, test it carefully then let's get it in then.
> > 
> 
> Does the mm tree also have a calm down period during release candidates ?

Yes, I try to not merge too much material late in the -rcs and in the merge
window.  Often it's not practical to merge things anyway, because people
prepare patches against mainline, which is ancient history...

> I have modified the patchset so now if rcu helpers are used from
> rculist.h then fine otherwise gcc warns you that you're using the
> helpers from list.h like this:
> 
> init/foo.c:13: warning: ‘__deprecated_list_add_rcu’ is deprecated (declared at include/linux/rculist.h:76)
> 
> But the build process doesn't fail anymore.
> 
> For that I added some ugly hacks in list.h and rculist.h but they
> definitively should be removed for mainline inclusion. I'm sending them
> in response to this email.

I wouldn't bother, really.  Let's just get it as good as we can and slam it
in.

> If we include this now, then people can have a chance to notice that
> rculist.h exists and fix their stuffs until 2.6.25 release
> candidates but I'll redo the patchset and give it some test around the
> 2.6.25-rc1 timeframe anyway.

I'm just about finished compilation-testing for 2.6.24-mm1 which is a
shame.  Please do a best-effort against 2.6.24-mm1 (hopefully I'll get that
out tomorrow) and I'll slip it into -rc1 if it gets through cross-build
testing without unfixable-with-my-patience-level problems.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/