linux-kernel - Re: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080203142506.2003e5cf@siona>
Date:	Sun, 3 Feb 2008 14:25:06 +0100
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	linux-kernel@...r.kernel.org, davem@...emloft.net,
	bryan.wu@...log.com, dhowells@...hat.com,
	Cyrill Gorcunov <gorcunov@...il.com>
Subject: Re: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE

[removed bogus @atmel.co address from Cc]

On Sun, 03 Feb 2008 14:22:18 +0300
Cyrill Gorcunov <gorcunov@...il.com> wrote:

> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>

Applied, thanks.

I found myself having to grep through include/linux to figure out what
this _AC macro was really all about, so I added this to the description:

    PAGE_SIZE is used both from assembly and C code. We want to have type
    specifiers when using it from C, but this will make the assembler
    confused, so we need to make it conditional.
    
    This is exactly what the _AC macro is for, so using it allows us to
    get rid of a few lines of cpp noise.

My first thought was "Autoconf", and it sent shivers down my spine ;-)

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/