linux-kernel - Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47A5F6FA.3000107@ru.mvista.com>
Date:	Sun, 03 Feb 2008 20:16:42 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Borislav Petkov <bbpetkov@...oo.de>
Subject: Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()

Bartlomiej Zolnierkiewicz wrote:

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

> Index: b/drivers/ide/ide-tape.c
> ===================================================================
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -3852,16 +3852,17 @@ static int idetape_identify_device (ide_
>  
>  	/* Check that we can support this device */
>  
> -	if (gcw.protocol !=2 )
> -		printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n");
> +	if (gcw.protocol != 2)
> +		printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n",
> +				gcw.protocol);
>  	else if (gcw.device_type != 1)
> -		printk(KERN_ERR "ide-tape: Device type is not set to tape\n");
> +		printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set "
> +				"to tape\n", gcw.device_type);
>  	else if (!gcw.removable)
>  		printk(KERN_ERR "ide-tape: The removable flag is not set\n");
>  	else if (gcw.packet_size != 0) {
> -		printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n");
> -		if (gcw.packet_size == 1)
> -			printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n");
> +		printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 "
> +				"bytes long\n", gcw.packet_size);

    Shouldn't it be either "packet size is not 12 byted" or "packet is not 12 
bytes long"?

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/