linux-kernel - Re: LPFC compilation error in 2.6.24-git12/git13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47A5FB58.8040404@garzik.org>
Date:	Sun, 03 Feb 2008 12:35:20 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Peter Teoh <htmldeveloper@...il.com>
CC:	Wenji Huang <wenji.huang@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: LPFC compilation error in 2.6.24-git12/git13

Peter Teoh wrote:
> --- lpfc_init.c.old     2008-02-03 19:26:20.000000000 +0800
> +++ drivers/scsi/lpfc/lpfc_init.c       2008-02-03 19:26:42.000000000 +0800
> @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
>         uint16_t iotag;
>         int bars = pci_select_bars(pdev, IORESOURCE_MEM);
> 
> -       if (pci_enable_device_bars(pdev, bars))
> +       if (pci_enable_device_io(pdev))
>                 goto out;


As already discussed and pointed out on LKML and linux-scsi, this is the 
wrong change.  Look at the line above the one you changed -- we want mem 
not io.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/